Implement volume resizing #116
Draft
+990
−780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronDewes
added a commit
to nirvati/longhorn-instance-manager
that referenced
this pull request
Feb 24, 2024
Once longhorn/longhorn-spdk-engine#116 is merged, this needs to be reverted
AaronDewes
added a commit
to nirvati/longhorn-instance-manager
that referenced
this pull request
Feb 25, 2024
Once longhorn/longhorn-spdk-engine#116 is merged, this needs to be reverted Signed-off-by: Aaron Dewes <[email protected]>
This works by resizing all replicas individually. Signed-off-by: Aaron Dewes <[email protected]>
|
This pull request is now in conflict. Could you fix it @AaronDewes? 🙏 |
|
The approach this takes is that individual replicas are all resized. A RAID device in spdk should be automatically resized if all underlying devices grow (https://github.com/longhorn/spdk/blob/6925ca6543e4ad5a5e3a5db09217ae16bf939831/module/bdev/raid/bdev_raid.c#L2102). |
|
There is a dm linear device on the top of a device created by SPDK, so need to handle the dm device when expanding a volume. |
|
This pull request is now in conflict. Could you fix it @AaronDewes? 🙏 |
1 similar comment
|
This pull request is now in conflict. Could you fix it @AaronDewes? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#8022
What this PR does / why we need it:
Currently, SPDK volumes can not be resized. This aims at fixing this, and allows both growing and shrinking volumes.
Special notes for your reviewer:
I've not contributed to Longhorn before and this is completely untested. I'm trying to implement & test this feature, this is just a draft.
Additional documentation or context